Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AOT compilation: rename flag; no longer experimental. #1033

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

cfallin
Copy link
Contributor

@cfallin cfallin commented Nov 4, 2024

The AOT compilation option is now no longer advertised as experimental; it is ready for general use for anyone who wishes to try it. It is still off by default, i.e., an opt-in feature.

This PR renames the flag to --enable-aot, and continues to accept the old flag spelling (--enable-experimental-aot) while printing a warning that it has been renamed.

The AOT compilation option is now no longer advertised as experimental;
it is ready for general use for anyone who wishes to try it. It is still
off by default, i.e., an opt-in feature.

This PR renames the flag to `--enable-aot`, and continues to accept the
old flag spelling (`--enable-experimental-aot`) while printing a warning
that it has been renamed.
Copy link
Member

@guybedford guybedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. Just needs a run of npm run format.

@cfallin cfallin merged commit 3cd3cd7 into main Nov 5, 2024
25 checks passed
@cfallin cfallin deleted the cfallin/aot-is-no-longer-experimental branch November 5, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants